Skip to content

Follow up fixes for Improving Chat Message Search #4889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Apr 21, 2025


  • Failure to find message id in db creates the context chat compose
  • Rotating the device leads to some wrong design & search window is closed.
  • Some file icons are not yet displayed as expected. For example on sermo in the "Filetype examples" (e.g. icons for zip files..)
  • Extract and add Compose Previews for each message type (will require a lot of a refactoring)
  • Test it out

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

…seChatAdapter.kt in ChatActivity.kt

Signed-off-by: rapterjet2004 <[email protected]>
@rapterjet2004 rapterjet2004 added the 2. developing Work in progress label Apr 21, 2025
@rapterjet2004 rapterjet2004 self-assigned this Apr 21, 2025
Signed-off-by: rapterjet2004 <[email protected]>
…r less boilerplate in the future.

Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
Copy link
Contributor

github-actions bot commented May 9, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4889-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

github-actions bot commented May 9, 2025

Codacy

Lint

TypemasterPR
Warnings9999
Errors99

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222119
Dodgy code7167
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310203

Lint increased!

@mahibi
Copy link
Collaborator

mahibi commented May 14, 2025

@rapterjet2004 what the sate of this PR? Asking as it's marked as "developing" and no reviewer is assigned.
Is it still work in progress or should it be reviewed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Followup improvements for search for chat messages
2 participants