-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: UI fixes for create/edit row dialogs #1621
base: main
Are you sure you want to change the base?
Conversation
87dccc5
to
531cad1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverts a change that was purposefully done recently
Adding @marcoambrosini for review. Maybe the size of the modals need a discussion. Or maybe expand/narrow buttons, maybe remembering users preference (in browser). |
Please remember to add labels |
We talked about this in our 1on1 with @enjeck, I think it's fine to keep size large for all these dialogs |
531cad1
to
814f3a1
Compare
Add labels where? The dialogs themselves already have the |
Signed-off-by: Cleopatra Enjeck M. <[email protected]>
Signed-off-by: Cleopatra Enjeck M. <[email protected]>
Signed-off-by: Cleopatra Enjeck M. <[email protected]>
c402dbb
to
2388187
Compare
src/shared/components/ncTable/partials/rowTypePartials/RowFormWrapper.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick on indentation, otherwise 👍
Signed-off-by: Cleopatra Enjeck M. <[email protected]>
Before
After
Before
After