feat(controllers): Migrate server annotations to attributes - #9377
Merged
Merged
Conversation
nickvergessen
added
3. to review
feature: api 🛠️
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
techdebt/noid/update-to-server-attributes
branch
from
April 26, 2023 07:18
cb6776e to
092b5aa
Compare
nickvergessen
marked this pull request as ready for review
April 26, 2023 07:41
vitormattos
reviewed
Apr 26, 2023
Comment on lines
+178
to
+179
| #[NoCSRFRequired] | ||
| #[PublicPage] |
Contributor
There was a problem hiding this comment.
Maybe would be good put all ordered.
Contributor
There was a problem hiding this comment.
We also can verify if possible create a rule at nextcloud/coding-standard about this.
Member
Author
There was a problem hiding this comment.
it's alphabetically ordered?
We also can verify if possible create a rule at nextcloud/coding-standard about this.
I guess that would be cool
Contributor
There was a problem hiding this comment.
Yes, because under this, have the attribute BruteForceProtection, unordered.
I did a fast look at friendsofphp/php-cs-fixer and didn't found a specific rule to do this.
vitormattos
approved these changes
Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🏁 Checklist
docs/has been updated or is not required