Skip to content

refactor: replace 'webrtcSupport' library by native checks - #19495

Merged
Antreesy merged 2 commits into
mainfrom
chore/deps/webrtcsupport-drop
Sep 20, 2026
Merged

Antreesy merged 2 commits into
mainfrom
chore/deps/webrtcsupport-drop

Conversation

@Antreesy

@Antreesy Antreesy commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

β˜‘οΈ Resolves

Note: window.location.protocol === 'https:' -> window.isSecureContext is technically correct, as screenshare supported on localhost

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

πŸ–ŒοΈ UI Checklist

No visual changes

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • πŸ–ŒοΈ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • πŸ“— User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

- library was doing the same native checks already
- keep used functions in browserCheck.ts
- replace all occurrences

Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the β˜ƒοΈ Next Major (36) milestone Sep 20, 2026
@Antreesy
Antreesy requested review from ShGKme and danxuliu September 20, 2026 16:21
@Antreesy Antreesy self-assigned this Sep 20, 2026
@Antreesy Antreesy added feature: WebRTC 🚑 WebRTC connection between browsers and/or mobile clients feature: frontend πŸ–ŒοΈ "Web UI" client dependencies Pull requests that update a dependency file labels Sep 20, 2026
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Sep 20, 2026
@Antreesy

Copy link
Copy Markdown
Contributor Author

/backport to stable35

@Antreesy
Antreesy merged commit 383f17d into main Sep 20, 2026
49 checks passed
@Antreesy
Antreesy deleted the chore/deps/webrtcsupport-drop branch September 20, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI assisted This PR contains AI-assisted commits dependencies Pull requests that update a dependency file feature: frontend πŸ–ŒοΈ "Web UI" client feature: WebRTC 🚑 WebRTC connection between browsers and/or mobile clients

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants