Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conversation): Add option to allow deleting one-to-one conversat… #14064

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jan 2, 2025

…ions

🛠️ API Checklist

🚧 Tasks

  • 1:1 conversation can be deleted permanently for both participants
  • Any of the 1:1 conversation participants can delete the conversation
  • The option “permanently delete the whole conversation” means that all messages will be deleted for both participants
  • The option “permanently delete conversation” must be implemented instead of “leave conversation” for 1:1 chat
  • For group chats leaving conversation and deletion policy remains unchanged, like it is now.

🏁 Checklist

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

lib/Service/RoomFormatter.php Outdated Show resolved Hide resolved
lib/Controller/RoomController.php Outdated Show resolved Hide resolved
lib/Controller/RoomController.php Outdated Show resolved Hide resolved
lib/Controller/RoomController.php Outdated Show resolved Hide resolved
@nickvergessen nickvergessen force-pushed the feat/noid/deletable-one-to-one branch from 9ccca2f to 00a8e4a Compare January 8, 2025 11:48
@nickvergessen nickvergessen merged commit 7629605 into main Jan 8, 2025
75 checks passed
@nickvergessen nickvergessen deleted the feat/noid/deletable-one-to-one branch January 8, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

2 participants