-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(signaling): add UI warning in call with 4+ participants #14022
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Maksim Sukharev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick comment, two things:
- the warning basically will be shown in any non 2 person call in the future
- we had this warning or a similar one in the past, can you check and find it or find where it got lost?
}, | ||
|
||
showSignalingInternalWarning(token) { | ||
if (this.$store.getters.isModerator || this.$store.getters.participantsList(token)?.length > 4) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (this.$store.getters.isModerator || this.$store.getters.participantsList(token)?.length > 4) { | |
if (this.$store.getters.participantsList(token)?.length > 2) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplified to group/public cconversations (as 2+ users only there) Or we should check amount of connected peers?
Never appeared after migration to Vue in 2019: 88d7d78 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue with the toast is that it gets clicked away and is not permanent enough. I would suggest to put a yellow NcNoteCard on the top of the right sidebar (or left navigation, although that seems to be less relevant if this only shows in a call) that shows throughout the duration of the call.
And it also needs to provide how to fix it – if shown to users, needs to say something actionable like "Contact your admin for further assistance"
If a sidebar it should be right, as left is folded away when starting a call. |
@nickvergessen we could show that warning generally though, even when not in a call? If only during a call is wanted, then yes best right sidebar. |
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist