Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SIP): get dial-in info from signaling settings #13928

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix(SIP): get dial-in info from signaling settings #13928

merged 1 commit into from
Jan 8, 2025
+42 −38

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 2, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🚧 Tasks

  • Make _trigger() work when initially create from Signaling

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added 3. to review feature: signaling 📶 Internal and external signaling backends technical debt labels Dec 2, 2024
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Dec 2, 2024
@Antreesy Antreesy requested a review from ShGKme December 2, 2024 16:18
@Antreesy Antreesy self-assigned this Dec 2, 2024
@Antreesy Antreesy force-pushed the fix/13904/get-dial-in-from-signaling branch from a24667f to ad41a2a Compare December 3, 2024 09:25
@Antreesy Antreesy marked this pull request as ready for review December 3, 2024 09:27
@Antreesy Antreesy requested a review from DorraJaouad January 7, 2025 11:29
DorraJaouad
DorraJaouad approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested but code looks good

@Antreesy Antreesy merged commit e5eee22 into main Jan 8, 2025
49 checks passed
@Antreesy Antreesy deleted the fix/13904/get-dial-in-from-signaling branch January 8, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review feature: signaling 📶 Internal and external signaling backends technical debt
Projects
None yet
Milestone
v21.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Read SIP dial information from signaling settings instead of initial state
2 participants
@Antreesy @DorraJaouad