Skip to content

System message reaction_revoked should contain, which reaction was revoked #14994

Description

@Antreesy

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Post a message
  2. Add a reaction
  3. Remove a reaction

Actual behaviour

POST to api/v1/reaction/{token}/{id}:

"data": {
    "\ud83d\udc4d": [
        {
            "actorType": "users",
            "actorId": "antreesy",
            "actorDisplayName": "Max Southgate",
            "timestamp": 1746019885
        }
    ]
}

DELETE to api/v1/reaction/{token}/{id}?reaction=%F0%9F%91%8D:

"data":{}

This also triggers GET request to api/v1/reaction/{token}/{id}, as other clients don't know, which and by whom a reaction was removed

GET messages after long polling, or chat loading:

[
  {
      "id": 576,
      "message": "{file}",
      "reactions": {
          "\ud83d\ude00": 1
      },
  },
  {
      "id": 577,
      "message": "Reaction deleted by author",
      "systemMessage": "reaction_deleted",
      "parent": {
          "id": 576,
      }
  },
  {
      "id": 578,
      "message": "You deleted a reaction",
      "systemMessage": "reaction_revoked",
      "parent": {
          "id": 576,
      }
  }
  {
      "id": 579,
      "message": "\ud83d\ude00", // This is missing on reaction_revoked
      "systemMessage": "reaction",
      "parent": {
          "id": 576,
          "reactions": {
              "\ud83d\ude00": 1
          },
      }
  }
]

Talk app

Talk app version: dev

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions