fix(external-share): move ExternalShareScanJob creation deeper - #64021
Draft
ArtificialOwl wants to merge 1 commit into
Draft
fix(external-share): move ExternalShareScanJob creation deeper#64021ArtificialOwl wants to merge 1 commit into
ArtificialOwl wants to merge 1 commit into
Conversation
ArtificialOwl
requested review from
Altahrim,
CarlSchwan,
provokateurin and
sorbaugh
and removed request for
a team
September 4, 2026 12:34
Member
Author
|
/backport to stable35 |
ArtificialOwl
marked this pull request as draft
September 4, 2026 12:34
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
ArtificialOwl
added
2. developing
ArtificialOwl
force-pushed
the
fix/noid/move-external-share-scan-deeper
branch
from
September 4, 2026 18:14
8648fdd to
82f050a
Compare
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
fix/noid/move-external-share-scan-deeper
branch
from
September 4, 2026 18:33
82f050a to
5c7f571
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This move the creation of the background job
ExternalShareScanJob- implemented with #61908 - deeper/closer to the Share Acceptance action.The reason for this change is that some path to reach the share acceptance (ie. auto-accept on trusted server) would not trigger the background job, therefor not scan the freshly created mountpoint.