Skip to content

fix(files): do not reject ownership transfer when free space is unlimited #64020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jo23sh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(files): do not reject ownership transfer when free space is unlimited #64020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/files/lib/Service/OwnershipTransferService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,9 @@ protected function analyse(
}
$size = $sourceFileInfo->getSize(false);
$freeSpace = $view->free_space($destinationUid . '/files/');
if ($size > $freeSpace && $freeSpace !== FileInfo::SPACE_UNKNOWN) {
// SPACE_UNKNOWN and SPACE_UNLIMITED mean there is no finite limit to compare against.
// SPACE_NOT_COMPUTED means a quota is set but its headroom is unknown, so it still rejects.
if ($freeSpace !== FileInfo::SPACE_UNKNOWN && $freeSpace !== FileInfo::SPACE_UNLIMITED && $size > $freeSpace) {
throw new TransferOwnershipException('Target user does not have enough free space available.', 1);
}

Expand Down