fix(files): validate dropped filenames before upload - #63997
Open
hamza221 wants to merge 2 commits into
Open
Conversation
Assisted-by: Codex:gpt-5.6-sol Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
Contributor
Author
|
/backport 53e8968 to stable35 |
Contributor
Author
|
/backport 53e8968 to stable34 |
Contributor
Author
|
/backport 53e8968 to stable33 |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnux
reviewed
Sep 3, 2026
| export async function onDropExternalFiles(root: RootDirectory, destination: IFolder, contents: INode[]): Promise<Upload[]> { | ||
| const invalidEntry = findInvalidDroppedEntry(root) | ||
| if (invalidEntry) { | ||
| showError(t('files', 'Cannot upload "{path}": {reason}', invalidEntry)) |
Contributor
There was a problem hiding this comment.
This should rather give the user a change to rename it to something valid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When uploading a file with a forbidden name
test\as an example it behaves differently depending on the upload method:For the sake of simplicity added a check before upload on drag and drop with error handling
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)
Assisted-by: Codex:gpt-5.6-sol