[stable35] fix: fail uploads when uri does not match session/share token - #63959
Merged
Conversation
backportbot
Bot
requested review from
AndyScherzinger,
CarlSchwan,
come-nc,
leftybournes,
salmart-dev,
sorbaugh and
susnux
and removed request for
a team,
AndyScherzinger and
susnux
September 2, 2026 14:14
AndyScherzinger
force-pushed
the
backport/63878/stable35
branch
2 times, most recently
from
September 2, 2026 17:56
42c002b to
0349493
Compare
This is a cosmetic change that can cause false security reports: the current implementation of the upload root collection returns UploadHome in every case, based on the current session, either the one of the logged in user, or for the share. The former allows uploading files in what looks like the upload folder of another user, but is in reality the one of the logged in user. Those requests will now fail with a 403 instead. Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Assisted-by: Claude:claude-sonnet-5 Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Assisted-by: Claude:claude-sonnet-5 Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
AndyScherzinger
force-pushed
the
backport/63878/stable35
branch
from
September 3, 2026 06:37
0349493 to
ca617eb
Compare
salmart-dev
approved these changes
Sep 3, 2026
AndyScherzinger
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #63878