fix: fail uploads when uri does not match session/share token - #63878
Open
salmart-dev wants to merge 3 commits into
Open
fix: fail uploads when uri does not match session/share token#63878salmart-dev wants to merge 3 commits into
salmart-dev wants to merge 3 commits into
Conversation
salmart-dev
force-pushed
the
fix/upload-home-match-uri
branch
from
September 1, 2026 13:50
75044c9 to
0f76eab
Compare
This is a cosmetic change that can cause false security reports: the current implementation of the upload root collection returns UploadHome in every case, based on the current session, either the one of the logged in user, or for the share. The former allows uploading files in what looks like the upload folder of another user, but is in reality the one of the logged in user. Those requests will now fail with a 403 instead. Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Assisted-by: Claude:claude-sonnet-5 Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Assisted-by: Claude:claude-sonnet-5 Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
salmart-dev
force-pushed
the
fix/upload-home-match-uri
branch
from
September 1, 2026 13:58
0f76eab to
e405683
Compare
Contributor
Author
|
/backport to stable35 |
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
salmart-dev
marked this pull request as ready for review
September 1, 2026 14:00
salmart-dev
requested review from
Altahrim,
CarlSchwan,
icewind1991 and
leftybournes
and removed request for
a team
September 1, 2026 14:00
susnux
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a cosmetic change that can cause false security reports: the current implementation of the upload root collection returns
UploadHomein every case, based on the current session, either the one of the logged in user, or for the share. The former allows uploading files in what looks like the upload folder of another user, but is in reality the one of the logged in user. Those requests will now fail with a 403 instead.Checklist
3. to review, feature component)stable32)AI (if applicable)