fix(core): make the app store link in the app menu configurable - #63860
Merged
Conversation
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
marked this pull request as ready for review
August 31, 2026 14:22
pringelmann
requested review from
Altahrim,
jancborchardt,
kra-mo,
kristian-zendato,
leftybournes,
salmart-dev,
skjnldsv and
sorbaugh
and removed request for
a team
August 31, 2026 14:23
jancborchardt
approved these changes
Aug 31, 2026
jancborchardt
left a comment
Member
There was a problem hiding this comment.
Nice refinement, as discussed :)
CarlSchwan
approved these changes
Aug 31, 2026
kra-mo
approved these changes
Aug 31, 2026
susnux
approved these changes
Aug 31, 2026
Contributor
Author
|
/backport to stable35 |
Contributor
Author
|
/backport to stable34 |
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Non-admins get an "App store" tile linking to apps.nextcloud.com with no way to turn it off.
This introduces a new config key
appstore_link_shown, with preset defaults:An explicitly set value always wins. Otherwise the link is hidden when
appstoreenabledis off or a subscription is available, else the preset default applies. No preset means the link stays, so upgrades don't change.This does also broaden
appstoreenabled. It used to only gate installing from the store, now it hides the link too.Checklist
3. to review, feature component)stable32)AI (if applicable)