fix: Make Vue's ldapGroupMemberAssocAttr label map LcValue-compatible - #63672
Open
j-frei wants to merge 2 commits into
Open
fix: Make Vue's ldapGroupMemberAssocAttr label map LcValue-compatible#63672j-frei wants to merge 2 commits into
j-frei wants to merge 2 commits into
Conversation
Signed-off-by: Johann Frei <johann_frei@yahoo.de>
j-frei
requested review from
kristian-zendato,
skjnldsv and
sorbaugh
and removed request for
a team
August 26, 2026 14:49
joshtrichards
approved these changes
Aug 29, 2026
joshtrichards
left a comment
joshtrichards
left a comment
Member
There was a problem hiding this comment.
Makes sense. As an aside, LDAP configuration frontend could really use test coverage! A future follow-up PR idea for someone.
Member
|
/backport to stable35 |
Member
|
/backport to stable34 |
Member
|
/backport to stable33 |
Member
|
@j-frei DCO check needs to be remedied https://github.com/nextcloud/server/pull/63672/checks?check_run_id=98282405379 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The user_ldap plugin features the field ldapGroupMemberAssocAttr and its values are converted into lowercase when set. In the UI, the field loads the labels using the groupMemberAssociation constant, which used to be case-sensitive.
It failed for all entries other than 'member' because these fields had upper letters in it; resulting in the settings panel to display the GUI field as empty.
This is fixed here. (Tested on v33.0.2)
It could be partially related to #60342, but just viewing the field before this PR did not change the ldap settings in my tests.