Skip to content

fix: clarify trashbin expiration CLI help #63160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvanhorn wants to merge 3 commits into
base: master
Choose a base branch
from
+3 −2
Open

fix: clarify trashbin expiration CLI help #63160

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c04117
fix: clarify trashbin expiration CLI help
mvanhorn Aug 11, 2026
966f8a3
fix: reword trashbin:expire help and drop the metadata assertion test
mvanhorn Aug 12, 2026
38e544a
fix(trashbin): drop the negative clause from expire help
mvanhorn Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/files_trashbin/lib/Command/ExpireTrash.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,12 @@ protected function configure(): void {
parent::configure();
$this
->setName('trashbin:expire')
->setDescription('Expires the users trashbin')
->setDescription('Delete expired files from the trashbin')
->setHelp('Deletes expired files from the trashbin according to the configured retention and space policy. This does not disable the trashbin or unconditionally empty it.')

@come-nc come-nc Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
->setHelp('Deletes expired files from the trashbin according to the configured retention and space policy. This does not disable the trashbin or unconditionally empty it.')
->setHelp('Deletes expired files from the trashbin according to the configured retention and space policy.')

The help should not detail what the command does not do, that is confusing.
It does not do a lot of other stuff as well.

@mvanhorn mvanhorn Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in 38e544a - the help string is now exactly your suggestion, with the "does not" clause dropped. Flagging it since the thread went outdated rather than resolved.

->addArgument(
'user_id',
InputArgument::OPTIONAL | InputArgument::IS_ARRAY,
'expires the trashbin of the given user(s), if no user is given the trash for all users will be expired'
'Limit processing to the given user ID(s); if no user ID is given, all users are processed'
);
}

Expand Down