Skip to content

[stable33] fix(onetime-qrcode): Fix onetime QR code with 2FA enable #62448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 2 commits into from
Jul 23, 2026
Merged

[stable33] fix(onetime-qrcode): Fix onetime QR code with 2FA enable #62448

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7054658
fix(onetime-qrcode): Fix onetime QR code with 2FA enable
nickvergessen Jul 23, 2026
44b256e
fix: Use NoTwoFactorRequired annotation instead of attribute
CarlSchwan Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/Controller/AppPasswordController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
use OCP\AppFramework\Http\Attribute\ApiRoute;
use OCP\AppFramework\Http\Attribute\BruteForceProtection;
use OCP\AppFramework\Http\Attribute\NoAdminRequired;
use OCP\AppFramework\Http\Attribute\NoTwoFactorRequired;
use OCP\AppFramework\Http\Attribute\PasswordConfirmationRequired;
use OCP\AppFramework\Http\Attribute\UseSession;
use OCP\AppFramework\Http\DataResponse;
Expand Down Expand Up @@ -204,6 +205,7 @@
* 200: App password returned
*/
#[NoAdminRequired]
#[NoTwoFactorRequired]

Check failure on line 208 in core/Controller/AppPasswordController.php

View workflow job for this annotation

GitHub Actions / static-code-analysis

UndefinedAttributeClass 

core/Controller/AppPasswordController.php:208:4: UndefinedAttributeClass: Attribute class OCP\AppFramework\Http\Attribute\NoTwoFactorRequired does not exist (see https://psalm.dev/241)
Comment thread
CarlSchwan marked this conversation as resolved.
Outdated
#[ApiRoute(verb: 'GET', url: '/getapppassword-onetime', root: '/core')]
public function getAppPasswordWithOneTimePassword(): DataResponse {
// Only allow with one-time app passwords
Expand Down
Loading