feat (contacts): format/clean emails of carddav

[timedin-de]

• Resolves: contacts/#4379

Summary

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[susnux]

Maybe instead of do server side sanitizing its better to only do this client side and on server do not sanitize but validate.
Meaning instead you could throw bad request when \OCP\Mail\IMailer::validateMailAddress fails for a mail address

[timedin-de]

Maybe instead of do server side sanitizing its better to only do this client side and on server do not sanitize but validate. Meaning instead you could throw bad request when \OCP\Mail\IMailer::validateMailAddress fails for a mail address

Yeah the problem is that davclients are very diverse and seemingly none do this email sanitize.

I agree will implement 👍. But we need to somehow inform the user when and why sync requests fail.

[SebastianKrupinski]

Hi @timedin-de

I agree with @susnux we should not sanitize or manipulate the data in the storage layer (CardDavBackend) this should be done further up in the chain, probably at the entry point to the server.

The user can be informed with a 400 error and a custom message of the issue.

[timedin-de]

@susnux @SebastianKrupinski So i hope i've met both you recommendations:

• Emails are only being trimmed not all spaces removed
• Implementation is in OCA\DAV\CardDAV\Validation\CardDavValidatePlugin. CardDavBackend stays untouched
• Added unit tests
• We return a 400 Error if the email is completely invalid on submit

For Website this works quite good even without the frontend changes. DavX⁵ seems to abort the whole sync process for all contacts :/

[susnux]

DavX⁵ seems to abort the whole sync process for all contacts :/

maybe open a issue on DavX