enh(SystemTag): Make MapperEvent webhook compatible #50916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
force-pushed
the
enh/make-tag-event-webhook-compatible
branch
from
401270b to
85bdd30
Compare
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
enh/make-tag-event-webhook-compatible
branch
from
85bdd30 to
a700715
Compare
julien-nc
approved these changes
Feb 20, 2025
| 'eventType' => $this->getEvent(), | ||
| 'objectType' => $this->getObjectType(), | ||
| 'objectId' => $this->getObjectId(), | ||
| 'tagIds' => $this->getTags(), |
There was a problem hiding this comment.
You trust the Php serialization because it's a list of ints?
There was a problem hiding this comment.
The description of IWebhookCompatibleEvent says it will be serialized using json_encode
susnux
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make MapperEvent webhook compatible so it can be used with the new Windmill Workflows
Checklist