chore: Adjust OCP\Server::get annotation to work with phpstan
#50908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added
3. to review
Comment on lines
+29
to
+30
| * @psalm-param class-string<T>|string $serviceName | ||
| * @psalm-return ($serviceName is class-string<T> ? T : mixed) |
There was a problem hiding this comment.
Suggested change
| * @psalm-param class-string<T>|string $serviceName | |
| * @psalm-return ($serviceName is class-string<T> ? T : mixed) | |
| * @psalm-param class-string<T> $serviceName | |
| * @psalm-return T |
Isn't this enough? If the class isn't found then an exception is thrown, so the return should be irrelevant.
There was a problem hiding this comment.
But it can also be an alias instead of just a class name, right?
There was a problem hiding this comment.
True, although it might be worth a try to remove it? Maybe it will be fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notices
\OCP\Server::getdoes not correctly work with my IDE, seems the previous annoations were too complex andTwas not referenced directly in a parameter, only in the constraint ofS, so it was not getting resolved.This annotation is simpler and also works with phpstan