fix(files_sharing): rate limit share creation 10 times per 10 minutes #50905
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: skjnldsv <[email protected]>
skjnldsv
requested review from
yemkareems and
come-nc
and removed request for
a team
|
/backport to stable31 |
|
/backport to stable30 |
susnux
reviewed
Feb 20, 2025
Co-authored-by: Ferdinand Thiessen <[email protected]> Signed-off-by: John Molakvoæ <[email protected]>
susnux
approved these changes
Feb 20, 2025
| @@ -557,6 +557,7 @@ public function deleteShare(string $id): DataResponse { | |||
| * 200: Share created | |||
| */ | |||
| #[NoAdminRequired] | |||
| #[UserRateLimit(limit: 10, period: 600)] | |||
There was a problem hiding this comment.
I can imagine valide use cases with higher rate, e.g. share to a list of emails.
So I would think 30s is a valid interval for humans here (20 per 10 minutes)?
|
For integration tests you need to create some app config for |
come-nc
approved these changes
Feb 20, 2025
yeah, me neither tbh 🤷 |
|
Integration needs excemption from rate limiting 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And adjust existing email sending UserRateLimit