Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transferownership): Allow searching new owner by email #50816

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

julien-nc
Copy link
Member

Issue

In the transfer ownership personal settings, searching the "new owner" with an email address didn't work. The search request is returning some users but they are not displayed in the NcSelect.

Fix

  • Make the NcSelect non filterable
  • Remove the label prop
  • Add a subname attribute to the options (with user.shareWithDisplayNameUnique as value)

Additional changes

  • Adjust style to have the label on top of the NcSelect
  • Give the NcSelect the same width as the "choose file" button. A larger NcSelect help to see the full title and subline of its option items.

Before

image

After

image

This could be backported to 29, 30 and 31.

…ithDisplayNameUnique in item subline, adjust style

Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc julien-nc added this to the Nextcloud 32 milestone Feb 14, 2025
@julien-nc julien-nc requested review from a team and susnux and removed request for a team February 14, 2025 16:31
@julien-nc julien-nc requested a review from skjnldsv as a code owner February 14, 2025 16:31
@julien-nc julien-nc requested review from skjnldsv and Pytal February 14, 2025 16:31
@julien-nc
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <[email protected]>
<label for="targetUser">
<span>{{ t('files', 'New owner') }}</span>
</label>
<NcSelect v-model="selectedUser"
input-id="targetUser"
:options="formatedUserSuggestions"
:multiple="false"
:filterable="false"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants