test(dashboard): Add regression test for loading unneeded data #50179
+37
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent a regression of #48403 Signed-off-by: Ferdinand Thiessen <[email protected]>
nickvergessen
approved these changes
Jan 14, 2025
| }) | ||
|
|
||
| it('Only load needed widgets', () => { | ||
| cy.intercept('**/dashboard/api/v2/widget-items?widgets%5B%5D=user_status').as('loadedWidgets') |
There was a problem hiding this comment.
how risky are we to API changes :P
There was a problem hiding this comment.
Would also work with
Suggested change
| cy.intercept('**/dashboard/api/v2/widget-items?widgets%5B%5D=user_status').as('loadedWidgets') | |
| cy.intercept('**/dashboard/api/v2/widget-items').as('loadedWidgets') |
There was a problem hiding this comment.
Feels a bit saver, but we don't have access to URL generation in JS, I forgot.
But maybe we could enable 1 widget and check that the intercept is exactly 1 instead?
There was a problem hiding this comment.
Sounds good but then only possible on 31+ as 30 and before only have one widget in server repo (user status).
There was a problem hiding this comment.
31+ sounds good, and for 30 we test with 0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist