Allow to revert automated status - #36854
Merged
nickvergessen merged 8 commits intoApr 18, 2023
Merged
Conversation
Member
|
Good idea 👍🏽 For the UI we could do it like this:
|
Member
Author
nickvergessen
force-pushed
the
feature/36852/allow-to-revert-automated-status
branch
from
February 27, 2023 21:03
65de366 to
fec199c
Compare
jancborchardt
requested changes
Mar 1, 2023
jancborchardt
left a comment
Member
There was a problem hiding this comment.
Nice! To make it a bit less jumpy as @nimishavijay noted, it would be good to add a little animation here. Best of the row you click "Reset" on moving up and fading away, sort of so it fades into the input field. :)
Member
Author
I'm not a frontender so can't help with that. The other option I would see is closing the modal which also happens when "Set status message" is used. |
jancborchardt
approved these changes
Mar 8, 2023
jancborchardt
left a comment
Member
There was a problem hiding this comment.
Nice as is now, the animation could be something for the future. Nice one @nickvergessen! :)
nickvergessen
force-pushed
the
feature/36852/allow-to-revert-automated-status
branch
from
April 14, 2023 11:47
fec199c to
b90e4c3
Compare
nickvergessen
marked this pull request as ready for review
April 14, 2023 11:47
nickvergessen
force-pushed
the
feature/36852/allow-to-revert-automated-status
branch
from
April 14, 2023 11:55
b90e4c3 to
aca4de9
Compare
This was referenced Apr 14, 2023
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
…he store Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
feature/36852/allow-to-revert-automated-status
branch
from
April 18, 2023 13:08
b48d718 to
63dc8cb
Compare
Antreesy
approved these changes
Apr 18, 2023
nickvergessen
deleted the
feature/36852/allow-to-revert-automated-status
branch
April 18, 2023 20:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
TODO
Follow up
Checklist