fix(files_versions): Do not expire versions newer than min age

The auto expire logic does not take into account the min retention age set by the admin. So versions were eagerly deleted. Fix #19791 Signed-off-by: Louis Chemineau <[email protected]>
nextcloud · Feb 19, 2025 · 0771906 · 0771906
1 parent c71bc06
commit 0771906
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/apps/files_versions/lib/Expiration.php b/apps/files_versions/lib/Expiration.php
@@ -98,6 +98,20 @@ public function isExpired(int $timestamp, bool $quotaExceeded = false): bool {
 		return $isOlderThanMax || $isMinReached;
 	}
 
+	/**
+	 * Get minimal retention obligation as a timestamp
+	 *
+	 * @return int|false
+	 */
+	public function getMinAgeAsTimestamp() {
+		$minAge = false;
+		if ($this->isEnabled() && $this->minAge !== self::NO_OBLIGATION) {
+			$time = $this->timeFactory->getTime();
+			$minAge = $time - ($this->minAge * 86400);
+		}
+		return $minAge;
+	}
+
 	/**
 	 * Get maximal retention obligation as a timestamp
 	 *

diff --git a/apps/files_versions/lib/Storage.php b/apps/files_versions/lib/Storage.php
@@ -696,7 +696,15 @@ protected static function getExpireList($time, $versions, $quotaExceeded = false
 		$expiration = self::getExpiration();
 
 		if ($expiration->shouldAutoExpire()) {
-			[$toDelete, $size] = self::getAutoExpireList($time, $versions);
+			// Exclude versions that are newer than the minimum age from the auto expiration logic.
+			$minAge = $expiration->getMinAgeAsTimestamp();
+			if ($minAge !== false) {
+				$versionsToAutoExpire = array_filter($versions, fn ($version) => $version['version'] < $minAge);
+			} else {
+				$versionsToAutoExpire = $versions;
+			}
+
+			[$toDelete, $size] = self::getAutoExpireList($time, $versionsToAutoExpire);
 		} else {
 			$size = 0;
 			$toDelete = [];  // versions we want to delete