fix: replace FakeUser with getExistingUser - #2782
Merged
Merged
Conversation
icewind1991
force-pushed
the
remove-fake-user
branch
from
February 5, 2026 14:25
b29a0dd to
0b34f95
Compare
nickvergessen
approved these changes
Feb 5, 2026
nickvergessen
left a comment
nickvergessen
left a comment
Member
There was a problem hiding this comment.
Had it already locally, was waiting for the OCP update but CI was slow
Signed-off-by: Robin Appelman <robin@icewind.nl>
nickvergessen
force-pushed
the
remove-fake-user
branch
from
February 5, 2026 15:13
0b34f95 to
eacc54b
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes code duplication and the need to ensure the signature stays up to date.