security page #179

jospoortvliet · 2016-10-12T15:50:23Z

Created a new security page as this is one of our major strengths.
Let me know what you think.
@LukasReschke more details are welcome
@jancborchardt @Espina2 feedback on looks welcome too.,

jospoortvliet · 2016-10-12T15:54:47Z

@Espina2 feel free to simply go in and make changes to the design/layout, of course.

Espina2 · 2016-10-12T16:12:43Z

Just have a quick look, and I think we wave many information at the same time. We should have more white space and better alignments. I will make this page my priority. :)

LukasReschke · 2016-10-12T18:37:14Z

page-secure.php

+</div>
+
+
+<div class="wrap container featureblock">


Is this element ever closed?

whoops, fixed.

jancborchardt · 2016-10-12T19:18:18Z

assets/css/secure.scss

+	height: 1100px;	
+
+	h1 {
+      font-size: 25px;


Just a detail but the indentation seems to be all mangled in these files. We use tabs everywhere. ;)

yeah, I know, it's a mess.... Should run a tool at some point which fixes it or something. Sorry!

jancborchardt · 2016-10-12T19:20:00Z

page-secure.php

+<div class="container-fluid background">
+	<div class="container">
+		<div class="col-md-6 topheader">
+			<h1>Security and Authentication</h1>


»authentication« lowercase here? Because we only capitalize the first word of headers.

jancborchardt · 2016-10-12T19:20:47Z

page-secure.php

+	<div class="container">
+		<div class="col-md-6 topheader">
+			<h1>Security and Authentication</h1>
+			<h2>Nextcloud is designed to protect user data through multiple layers of protection.</h2>


Nextcloud is designed to protect user data
through multiple layers of protection

Add a
between »data« and »through« so it doesn’t weirdly break. Also, no dot at the end.

jancborchardt · 2016-10-12T19:21:10Z

page-secure.php

+	<div class="row">
+		<div class="col-md-7">
+			<h2>Authentication capabilities</h2>
+			<p>The Nextcloud login system supports pluggable authentication including two-factor authentication and device specific passwords, complete with a list of connected browsers and devices on the users’ personal page.</p>


»log in« are two words. ;)

jancborchardt · 2016-10-12T19:25:26Z

Just some wording nitpicks. I’m sure @Espina2 can come up with an awesome layout. :) We should remove the border-radius from any images as that looks odd.

Also – we need a page like this for Design! :) cc @nextcloud/designers ref #140

skjnldsv · 2016-10-12T19:27:26Z

Don't have time to look into details, right now, but it looks pretty amazing!! 😱

jospoortvliet · 2016-10-17T10:01:24Z

guys, while this page might not be perfect, it is certainly as good as the features page for example - how about we put this live? It's a nice step forward, which is good enough to me ;-)

Waiting longer to merge just increases the chance for merge conflicts...

jospoortvliet · 2016-10-17T10:01:59Z

Esp @jancborchardt what do you think? I made the changes you requested, btw.

All done.

LukasReschke · 2016-10-17T10:16:25Z

@jospoortvliet Can you deploy this branch to staging?

jospoortvliet · 2016-10-17T12:17:48Z

Done that.
https://nextcloud.com/secure/?staging=true

TODO:

make it more clear that the bar is click-able. Make it auto-advance! No clue how...
shorten the bar one/two items?!?! Could remove release & design and put the info in.
add links to documentation about hardening etc etc

Henni · 2016-10-17T13:07:51Z

Looks great!
Only the processimg seems to need a bit more work:

The graphic splits apart on smaller screens. I'd prefer it if it would keep it's style similar to how it looks on larger screens.

The first link has a negative left margin of -25px which misaligns the image.

Both of these points are only small issues and might be fixed in a separate PR.

jancborchardt · 2016-10-17T13:12:00Z

can we have the arrow graphics as SVG? They look blurry on retina and when zoomed.
there are multiple h1 on the page which creates visual strangeness. Any page should have only one h1 (»Security and authentication« in this case) the rest is h2’s or h3’s respectively. (»Security process« should be h2, Requirements h3, Security bug bounties and Auth capabilities h2, Screenshots h2 again)
the HackerOne logo is too large and should be above the image instead of above the header

Espina2 · 2016-10-17T13:16:56Z

I created this illustration and I pretend to animate them. I think that communicate better what we are talking about. I already discuss this with @jospoortvliet and It can be done in a 2.0 version of this page.

What do you think @jancborchardt

jancborchardt · 2016-10-17T13:19:57Z

@Espina2 you rock! 🤘 Fits the header style better indeed. :)

jospoortvliet · 2016-10-17T18:39:42Z

Done all of it. Check it out ;-)
https://nextcloud.com/secure/?staging=true

Ok to merge? We can add the nice image from Paulo once he has it finished in a separate PR.

It now automatically switches between tabs, every 3 secs. If you click it pauses for 15 seconds so you can click around manually.

jancborchardt · 2016-10-17T20:51:52Z

Just 1 thing: Change the h2 styles from 60px (same as h1) to 40px. And h3 from 35px to 30px. Then it’s ok. :)

skjnldsv · 2016-10-18T06:58:42Z

padding incorrect for 2 & 3 :)

jancborchardt · 2016-10-18T08:01:37Z

@skjnldsv and why is the font serif on your machine? ;)

skjnldsv · 2016-10-18T08:04:13Z

Because you're using Open Sans on the svg and I don't have it installed :p

skjnldsv · 2016-10-18T08:05:44Z

ps:

$ svgo Desktop/requirements.svg 
Done in 127 ms!
1.977 KiB - 65.8% = 0.677 KiB

ps2: sry Jan :D

jospoortvliet · 2016-10-18T09:55:22Z

@skjnldsv what padding is wrong?

jospoortvliet · 2016-10-18T09:55:41Z

All changes are deployed, btw:
https://nextcloud.com/secure/?staging=true

skjnldsv · 2016-10-18T09:56:48Z

@jospoortvliet 👍 for svg optimisation! :)
I meant the second and third. The text seems too far on the left!

PS: Better with the last opensans fix! 🚀

jospoortvliet · 2016-10-18T10:02:42Z

@skjnldsv yeah, the text is center aligned. It probably would look better to actually not do that but put the longer texts a bit more to the right... but I'm no designer so I just do 'center center' and done. Will deploy now, we can fix this, still, though, if you and perhaps Jan/Paulo agree it should be aligned differently.

skjnldsv · 2016-10-18T10:07:11Z

👍
Still some svg to do but great! :)

./assets/files/Nextcloud-Box-Assembly-Guide.svg

Done in 1047 ms!
263.274 KiB - 61% = 102.566 KiB

./assets/img/enterprise/education.svg

Done in 98 ms!
3.998 KiB - 57.5% = 1.7 KiB

./assets/img/enterprise/nocheck.svg

Done in 116 ms!
4.403 KiB - 97.8% = 0.096 KiB

./assets/img/enterprise/check.svg

Done in 124 ms!
4.095 KiB - 75.1% = 1.02 KiB

./assets/img/enterprise/optional.svg

Done in 127 ms!
4.425 KiB - 78.3% = 0.959 KiB

./assets/img/enterprise/publicsector.svg

Done in 116 ms!
9.551 KiB - 61.9% = 3.644 KiB

Done in 178 ms!
12.438 KiB - 18.7% = 10.112 KiB

./assets/img/conference/conf-logo.svg

Done in 158 ms!
23.613 KiB - 45.2% = 12.945 KiB

./assets/img/5years/5years.svg

Done in 118 ms!
8.124 KiB - 8.5% = 7.435 KiB

./assets/img/social/rss.svg

Done in 68 ms!
0.725 KiB - 17% = 0.602 KiB

./assets/img/social/twitter.svg

Done in 81 ms!
1.473 KiB - 2.3% = 1.439 KiB

./assets/img/federation/federation-logo.svg

Done in 116 ms!
5.12 KiB - 10.7% = 4.572 KiB

./assets/img/history/office.svg

Done in 106 ms!
3.428 KiB - 56.7% = 1.485 KiB

./assets/img/history/release.svg

Done in 128 ms!
6.576 KiB - 30.6% = 4.562 KiB

./assets/img/history/desktop.svg

Done in 105 ms!
3.458 KiB - 51.7% = 1.67 KiB

./assets/img/history/org.svg

Done in 137 ms!
6.576 KiB - 30.6% = 4.562 KiB

./assets/img/history/github.svg

Done in 106 ms!
3.42 KiB - 52.3% = 1.633 KiB

./assets/img/history/meeting.svg

Done in 107 ms!
3.605 KiB - 49.4% = 1.825 KiB

./assets/img/history/neutral.svg

Done in 149 ms!
14.93 KiB - 16.7% = 12.443 KiB

./assets/img/history/inc.svg

Done in 165 ms!
14.88 KiB - 16.3% = 12.46 KiB

./assets/img/history/mobile.svg

Done in 106 ms!
3.351 KiB - 53% = 1.573 KiB

./assets/img/history/code.svg

Done in 106 ms!
3.403 KiB - 52.5% = 1.618 KiB

./assets/img/history/press.svg

Done in 106 ms!
3.332 KiB - 53.2% = 1.559 KiB

./assets/img/history/money.svg

Done in 107 ms!
3.531 KiB - 50.7% = 1.739 KiB

./assets/img/history/statistics.svg

Done in 106 ms!
3.19 KiB - 55.8% = 1.409 KiB

jospoortvliet added 2 commits October 12, 2016 17:44

security page

d78df70

put custom.css back to what it was

1c71363

LukasReschke reviewed Oct 12, 2016

View reviewed changes

jancborchardt previously requested changes Oct 12, 2016

View reviewed changes

jospoortvliet added 5 commits October 13, 2016 10:29

feedback Jan

778e897

hackerone more prominently

c6ed4ce

add the Rhino blog

ebbe5ed

Merge branch 'master' into security

1cad96b

minor

76fb029

implement all feedback

86e1f0b

last comments from Jan

ff02efa

jospoortvliet added 2 commits October 18, 2016 11:44

clean up images and fix SVGs on systems without OpenSans

94d46ea

optimize more svgs

3280652

jospoortvliet added 2 commits October 18, 2016 12:00

center align all again

d736da9

optimize again :D

7bc8bdd

jospoortvliet merged commit c096686 into master Oct 18, 2016

jospoortvliet deleted the security branch October 18, 2016 10:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

security page #179

security page #179

jospoortvliet commented Oct 12, 2016

jospoortvliet commented Oct 12, 2016

Espina2 commented Oct 12, 2016

LukasReschke Oct 12, 2016

jospoortvliet Oct 17, 2016

jancborchardt Oct 12, 2016

jospoortvliet Oct 17, 2016

jancborchardt Oct 12, 2016

jancborchardt Oct 12, 2016

jancborchardt Oct 12, 2016

jancborchardt commented Oct 12, 2016

skjnldsv commented Oct 12, 2016

jospoortvliet commented Oct 17, 2016

jospoortvliet commented Oct 17, 2016

LukasReschke commented Oct 17, 2016

jospoortvliet commented Oct 17, 2016 •

edited

Loading

Henni commented Oct 17, 2016 •

edited by jospoortvliet

Loading

jancborchardt commented Oct 17, 2016 •

edited by jospoortvliet

Loading

Espina2 commented Oct 17, 2016

jancborchardt commented Oct 17, 2016

jospoortvliet commented Oct 17, 2016 •

edited

Loading

jancborchardt commented Oct 17, 2016

skjnldsv commented Oct 18, 2016

jancborchardt commented Oct 18, 2016

skjnldsv commented Oct 18, 2016

skjnldsv commented Oct 18, 2016 •

edited

Loading

jospoortvliet commented Oct 18, 2016

jospoortvliet commented Oct 18, 2016

skjnldsv commented Oct 18, 2016 •

edited

Loading

jospoortvliet commented Oct 18, 2016

skjnldsv commented Oct 18, 2016

security page #179

security page #179

Conversation

jospoortvliet commented Oct 12, 2016

jospoortvliet commented Oct 12, 2016

Espina2 commented Oct 12, 2016

LukasReschke Oct 12, 2016

Choose a reason for hiding this comment

jospoortvliet Oct 17, 2016

Choose a reason for hiding this comment

jancborchardt Oct 12, 2016

Choose a reason for hiding this comment

jospoortvliet Oct 17, 2016

Choose a reason for hiding this comment

jancborchardt Oct 12, 2016

Choose a reason for hiding this comment

jancborchardt Oct 12, 2016

Choose a reason for hiding this comment

jancborchardt Oct 12, 2016

Choose a reason for hiding this comment

jancborchardt commented Oct 12, 2016

skjnldsv commented Oct 12, 2016

jospoortvliet commented Oct 17, 2016

jospoortvliet commented Oct 17, 2016

LukasReschke commented Oct 17, 2016

jospoortvliet commented Oct 17, 2016 • edited Loading

Henni commented Oct 17, 2016 • edited by jospoortvliet Loading

jancborchardt commented Oct 17, 2016 • edited by jospoortvliet Loading

Espina2 commented Oct 17, 2016

jancborchardt commented Oct 17, 2016

jospoortvliet commented Oct 17, 2016 • edited Loading

jancborchardt commented Oct 17, 2016

skjnldsv commented Oct 18, 2016

jancborchardt commented Oct 18, 2016

skjnldsv commented Oct 18, 2016

skjnldsv commented Oct 18, 2016 • edited Loading

jospoortvliet commented Oct 18, 2016

jospoortvliet commented Oct 18, 2016

skjnldsv commented Oct 18, 2016 • edited Loading

jospoortvliet commented Oct 18, 2016

skjnldsv commented Oct 18, 2016

jospoortvliet commented Oct 17, 2016 •

edited

Loading

Henni commented Oct 17, 2016 •

edited by jospoortvliet

Loading

jancborchardt commented Oct 17, 2016 •

edited by jospoortvliet

Loading

jospoortvliet commented Oct 17, 2016 •

edited

Loading

skjnldsv commented Oct 18, 2016 •

edited

Loading

skjnldsv commented Oct 18, 2016 •

edited

Loading