fix: do not fail on invalid time strings

[blizzz]

Fixes the updater job to fail with:

    "Exception": "DateMalformedStringException",
    "Message": "Failed to parse time string (GgZzIMMLoE/7N24qteM295g8pA) at position 0 (G): The timezone could not be found in the database",

I had this for a long while until I actually looked into it. And suddenly I get articles from other feeds again 😅 I suppose I have (had?) one feed that provides invalid data, causing this issue.

DateMalformedStringException was introduced with PHP 8.3 only so to keep compatibility with 8.2 the catch goes against the general \Exception.

If intertested, unfold to see my stack trace.

{
  "reqId": "4CoKlJOL9g3G2CEHgaud",
  "level": 3,
  "time": "2024-12-15T18:20:34+00:00",
  "remoteAddr": "",
  "user": "--",
  "app": "core",
  "method": "",
  "url": "--",
  "message": "Error while running background job OCA\\News\\Cron\\UpdaterJob (id: 5806, arguments: null)",
  "userAgent": "--",
  "version": "30.0.2.2",
  "exception": {
    "Exception": "DateMalformedStringException",
    "Message": "Failed to parse time string (GgZzIMMLoE/7N24qteM295g8pA) at position 0 (G): The timezone could not be found in the database",
    "Code": 0,
    "Trace": [
      {
        "file": "/path/to/nextcloud/apps/news/lib/Fetcher/FeedFetcher.php",
        "line": 133,
        "function": "__construct",
        "class": "DateTime",
        "type": "->"
      },
      {
        "file": "/path/to/nextcloud/apps/news/lib/Service/FeedServiceV2.php",
        "line": 284,
        "function": "fetch",
        "class": "OCA\\News\\Fetcher\\FeedFetcher",
        "type": "->"
      },
      {
        "file": "/path/to/nextcloud/apps/news/lib/Service/FeedServiceV2.php",
        "line": 376,
        "function": "fetch",
        "class": "OCA\\News\\Service\\FeedServiceV2",
        "type": "->"
      },
      {
        "file": "/path/to/nextcloud/apps/news/lib/Service/UpdaterService.php",
        "line": 63,
        "function": "fetchAll",
        "class": "OCA\\News\\Service\\FeedServiceV2",
        "type": "->"
      },
      {
        "file": "/path/to/nextcloud/apps/news/lib/Cron/UpdaterJob.php",
        "line": 58,
        "function": "update",
        "class": "OCA\\News\\Service\\UpdaterService",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/path/to/nextcloud/lib/public/BackgroundJob/Job.php",
        "line": 61,
        "function": "run",
        "class": "OCA\\News\\Cron\\UpdaterJob",
        "type": "->"
      },
      {
        "file": "/path/to/nextcloud/lib/public/BackgroundJob/TimedJob.php",
        "line": 83,
        "function": "start",
        "class": "OCP\\BackgroundJob\\Job",
        "type": "->"
      },
      {
        "file": "/path/to/nextcloud/lib/public/BackgroundJob/TimedJob.php",
        "line": 73,
        "function": "start",
        "class": "OCP\\BackgroundJob\\TimedJob",
        "type": "->"
      },
      {
        "file": "/path/to/nextcloud/cron.php",
        "line": 162,
        "function": "execute",
        "class": "OCP\\BackgroundJob\\TimedJob",
        "type": "->"
      }
    ],
    "File": "/path/to/nextcloud/apps/news/lib/Fetcher/FeedFetcher.php",
    "Line": 133,
    "message": "Error while running background job OCA\\News\\Cron\\UpdaterJob (id: 5806, arguments: null)",
    "exception": {},
    "CustomMessage": "Error while running background job OCA\\News\\Cron\\UpdaterJob (id: 5806, arguments: null)"
  }
}

[SMillerDev]

I'm not sure if we want to pretend the broken feeds are actually valid.

[SMillerDev]

Isn't this a duplicate with the catch?

[blizzz]

Aye, $pubDT = $lastModified; could be moved after line 300, then we do not need the else branch and can have the catch block empty.

[blizzz]

I'm not sure if we want to pretend the broken feeds are actually valid.

Right now it is a hard failure and the whole update process crashes. Not following feeds are updated. So this has to be caught, and with my code changes it would just continue as if $httpLastNotified was null (default) or pubDate or published not set. So, it just falls back to normal behaviour.

[Grotax]

@SMillerDev do you still want to refactor the code a bit or should we merge it?