Fix issue that proxy port is removed if it matches the standard port #3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grotax
force-pushed
the
proxy
branch
2 times, most recently
from
eb171d1 to
df01931
Compare
SMillerDev
reviewed
Jan 8, 2025
docker/Dockerfile
Outdated
| @@ -5,7 +5,7 @@ FROM nextcloud:30-apache | |||
|
|
|||
| COPY entrypoint.sh / | |||
|
|
|||
| RUN apt-get update && apt-get install -y sqlite3 | |||
| RUN apt-get update && apt-get install -y sqlite3 nano | |||
There was a problem hiding this comment.
I think this is user preference, do we really want to install this?
There was a problem hiding this comment.
Not sure I just want a proper setup within the docker container to do stuff, I will drop it from this PR and check for alternatives
Grotax
force-pushed
the
proxy
branch
2 times, most recently
from
db5f551 to
aad721c
Compare
Grotax
changed the title
Grotax
added
API
Signed-off-by: Benjamin Brahmer <[email protected]>
Signed-off-by: Benjamin Brahmer <[email protected]>
Signed-off-by: Benjamin Brahmer <[email protected]>
wofferl
approved these changes
Jan 8, 2025
Grotax
added a commit
that referenced
this pull request
Jan 10, 2025
Changed - add explanations for the individual values in the feed information table (#3031) - show error message from `opml` import in web-ui (#3036) - disable new setting "nextUpdateTime" introduced in #2999 by default (#3039) Fixed - fix proxy port removed if standard port for the protocol (#3027) - background updater may stumble over invalid datetime strings from feeds (#3028) Signed-off-by: Benjamin Brahmer <[email protected]>
Merged
Grotax
added a commit
that referenced
this pull request
Jan 10, 2025
Changed - add explanations for the individual values in the feed information table (#3031) - show error message from `opml` import in web-ui (#3036) - disable new setting "nextUpdateTime" introduced in #2999 by default (#3039) Fixed - fix proxy port removed if standard port for the protocol (#3027) - background updater may stumble over invalid datetime strings from feeds (#3028) Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add debug logging for the proxy configuration
And add nano to the docker image to edit files.
Checklist