OPML If title field does not exist look for text #3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Brahmer <[email protected]>
Grotax
force-pushed
the
fix/opmlImport
branch
from
fee5bb3 to
7f2a57f
Compare
SMillerDev
approved these changes
Dec 31, 2024
give feed test better name Signed-off-by: Benjamin Brahmer <[email protected]>
Grotax
added a commit
that referenced
this pull request
Jan 2, 2025
Changed - Set maximum delay for updates to "in one day" (#3015) - add an information list for feeds that displays data such as last or next update dates (#3021) Fixed - OPML import use text field for title if title field is missing (#3016) Signed-off-by: Benjamin Brahmer <[email protected]>
Merged
Grotax
added a commit
that referenced
this pull request
Jan 2, 2025
Changed - Set maximum delay for updates to "in one day" (#3015) - add an information list for feeds that displays data such as last or next update dates (#3021) Fixed - OPML import use text field for title if title field is missing (#3016) Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checked the code and indeed when News exports to opml we set both title and text to the feed title.
So I guess some exporters might choose to only put it in text. So let's check for title first and if that is missing take text :)
Checklist