Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TypeError: this.$refs.actions.$refs.menuButton is undefined when tabbing through feeds and folders #3004

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

wofferl
Copy link
Collaborator

@wofferl wofferl commented Dec 23, 2024

Summary

With Nextcloud Vue 8.22.0 (#3003) the refs for the NcActionButton action menus are fixed, for single action it must be set itself.

Checklist

@wofferl wofferl merged commit 860471d into nextcloud:master Dec 24, 2024
23 of 24 checks passed
@Rudd-O
Copy link

Rudd-O commented Dec 29, 2024

Thanks!

Grotax added a commit that referenced this pull request Dec 30, 2024
Changed
- API add new field to Feed that indicates when the next update will be done "nextUpdateTime" (#2993)
- Change logic to update feed only if the nextUpdateTime has been reached (#2999)
- Add setting to disable the usage of nextUpdateTime (#2999)

Fixed
- `TypeError: this.$refs.actions.$refs.menuButton is undefined` when tabbing through feeds and folders (#3004)

Signed-off-by: Benjamin Brahmer <[email protected]>
@Grotax Grotax mentioned this pull request Dec 30, 2024
Grotax added a commit that referenced this pull request Dec 30, 2024
Changed
- API add new field to Feed that indicates when the next update will be done "nextUpdateTime" (#2993)
- Change logic to update feed only if the nextUpdateTime has been reached (#2999)
- Add setting to disable the usage of nextUpdateTime (#2999)

Fixed
- `TypeError: this.$refs.actions.$refs.menuButton is undefined` when tabbing through feeds and folders (#3004)

Signed-off-by: Benjamin Brahmer <[email protected]>
@wofferl wofferl deleted the fix_tabindex branch January 3, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants