-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new field nextUpdateTime to feed #2993
Conversation
@SMillerDev any idea what do about the failing tests? I tested it on my machine and the tests are fine. My system is a 64bit Manjaro though and my jq seems to know how to handle the output. I can imagine that it fails because of 4090814535 which is bigger than max 32bit int. Maybe if I print the jq version in actions I can get more information. It worked before as string of course since those can be much longer |
ff32b7a
to
a63877e
Compare
I simply changed the date of the test to some years earlier, idk why jq in this environment can't handle 64bit numbers in theory it should be able to... As a logical consequence at some point 32 bit clients or libraries that struggle with big numbers will have issues with this but I think they should be able to fix that. |
59660f3
to
ed9fef2
Compare
ed9fef2
to
37b7c2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Grotax, just one tweak.
Co-authored-by: Sean Molenaar <[email protected]> Signed-off-by: Benjamin Brahmer <[email protected]>
bee8366
to
59b975f
Compare
Changed - API add new field to Feed that indicates when the next update will be done "nextUpdateTime" (#2993) - Change logic to update feed only if the nextUpdateTime has been reached (#2999) - Add setting to disable the usage of nextUpdateTime (#2999) Fixed - `TypeError: this.$refs.actions.$refs.menuButton is undefined` when tabbing through feeds and folders (#3004) Signed-off-by: Benjamin Brahmer <[email protected]>
Changed - API add new field to Feed that indicates when the next update will be done "nextUpdateTime" (#2993) - Change logic to update feed only if the nextUpdateTime has been reached (#2999) - Add setting to disable the usage of nextUpdateTime (#2999) Fixed - `TypeError: this.$refs.actions.$refs.menuButton is undefined` when tabbing through feeds and folders (#3004) Signed-off-by: Benjamin Brahmer <[email protected]>
Summary
This is a first step to modernize the update cycle, the idea is to not fetch feeds on a fixed schedule.
feed-io provides a function to calculate the timestamp when an update would make sense.
This timestamp gets stored in the feed model now and can be used in a future PR to decide if we update a feed or not.
This is of course with feeds in mind that work like "normal" news feeds there might be special use case feeds that do not work well with this approach. But News does not claim to be the perfect solution for everything it is a feed reader and server api that helps users to consume feeds from different sources.
This also adds a new field to the API: nextUpdateTime contains a timestamp which indicates when the next update is due
Checklist