feat: emulate structural heading navigation to workaround problems with screen readers and the dynamic scroll #2978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th screen readers and the dynamic scroll Signed-off-by: Wolfgang <[email protected]>
SMillerDev
approved these changes
Dec 12, 2024
Grotax
added a commit
that referenced
this pull request
Dec 16, 2024
Changed - Show red error bubble only if more than 8 updates fail. (#2955) - Emulate structural heading navigation in screen reader mode with the jump to previous/next articles keys (#2978) - Add `PageDown` and `PageUp` for article heading navigation in screen reader mode (#2978) Fixed - set correct input focus when opening `AddFeed` or `Share` modals (#2965) - add item url to open website button aria label for screen readers (#2965) - allow using `toggle starred` and `mark read` icons with keyboard (#2965) - remove close button from list items in screen reader mode (#2965) - mark read on scroll marks visible items as read using vertical compact display mode (#2965) - Items read on other devices do not disappear on pressing 'r' (#2981) Signed-off-by: Benjamin Brahmer <[email protected]>
Merged
Grotax
added a commit
that referenced
this pull request
Dec 16, 2024
Changed - Show red error bubble only if more than 8 updates fail. (#2955) - Emulate structural heading navigation in screen reader mode with the jump to previous/next articles keys (#2978) - Add `PageDown` and `PageUp` for article heading navigation in screen reader mode (#2978) Fixed - set correct input focus when opening `AddFeed` or `Share` modals (#2965) - add item url to open website button aria label for screen readers (#2965) - allow using `toggle starred` and `mark read` icons with keyboard (#2965) - remove close button from list items in screen reader mode (#2965) - mark read on scroll marks visible items as read using vertical compact display mode (#2965) - Items read on other devices do not disappear on pressing 'r' (#2981) Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR will change the article navigation in screen reader mode to workaround problems with the dynamic scroll and screen reader software.
When switching between articles with the keyboard shortcuts the article title link will be focused as starting point for reading the article.
If the focus switches to the previous or next article, for e.g. when using tab or other navigation keys, the article will be automatically selected, to prevent the navigation from getting lost.
Checklist