never tag a release as nightly in the appstore #2894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Brahmer <[email protected]>
SMillerDev
approved these changes
Nov 19, 2024
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As mentioned by the docs nightly releases are meant for automated (nightly) builds, which we do not have, therefore changing the setting to false.
Also I want to change the format of the version for pre-releases by adding a dot.
25.0.0-alpha14 would become 25.0.0-alpha.14 both are valid semver versions but it seems like many nextcloud apps use the later format so I would like to adjust to that.
Fingers crossed that the appstore will actually understand that those are pre-releases.
https://docs.nextcloud.com/server/latest/developer_manual/app_publishing_maintenance/release_process.html#pre-releases
Checklist