-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add OPML Import API #2886
Conversation
Since my environment is still broken I couldn't test this one either. |
Signed-off-by: Sean Molenaar <[email protected]>
cdfa376
to
2d1f6f5
Compare
I got $this->request->files seems not to handled like an object and the content must probably be taken from the tmp file.
|
this will work:
|
I gues I must have read the docs for a wrong version of symfony? Let's use your version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All we need now for the importer is the handling of duplicate and incorrect feeds.
The importer currently still aborts in $this->feedService->create on the first problem (existing or faulty feed).
The existing fee could be handled with an extra check in OpmlService.php before the create. But for the faulty ones we would have to do an extra handling, if we want to add them. Possibly a create without initial fetch.
I really don't want to add faulty feeds. Those should really error out iyam. For duplication, I guess we'll have to do some checking. |
Summary
This adds an API that will take an OPML file as either a File upload with the name
file
, or as a request body.Checklist