fix feed title issues #2872
Merged
fix feed title issues #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grotax
force-pushed
the
fix/empty-title
branch
from
428e946 to
e844062
Compare
SMillerDev
reviewed
Nov 13, 2024
Grotax
force-pushed
the
fix/empty-title
branch
3 times, most recently
from
be932de to
6cfef41
Compare
SMillerDev
reviewed
Nov 13, 2024
|
I wasn't really able to see what your change would do and commited it, I'm not sure if that is what we want though. I think with your change we would always set the title to the hostname which is not what we want. |
|
Ah, I guess you're right. I thought |
Grotax
force-pushed
the
fix/empty-title
branch
from
5dcdcf9 to
8d67e67
Compare
Co-authored-by: Sean Molenaar <[email protected]> Signed-off-by: Benjamin Brahmer <[email protected]>
Grotax
force-pushed
the
fix/empty-title
branch
from
8d67e67 to
05e9819
Compare
SMillerDev
approved these changes
Nov 13, 2024
Grotax
added a commit
that referenced
this pull request
Nov 19, 2024
This is a major new release with a lot of changes. The frontend of news was rewritten from scratch to change to Vue.js coming from the original implementation with AngularJS. Also we require PHP 8.2 now and support Nextcloud 29 and 30. For the full Changelog checkout the entries for 25.0.0-alpha1 to 25.0.0. Changes since 25.0.0-alpha14 The following changes and fixes were done since the last alpha version 14. Changed - If title of feed is empty during creation set hostname of feed as title (#2872) - Add command to import OPML file - Add API to import OPML file or request body - add import/export `opml` to user settings (#2541) - Remove non-functional unread and starred filter - add single column layout (compact mode) (#2505) - add horizontal split layout (expanded compact mode) (#2505) - Allow to further drag the `feedview` list (and/or provide alternative view) (#2505) Fixed - Feed without Title returned by DB causes exception (#2872) - Keep Unread is now respected during mark read on scroll and is kept during feed/folder changes Signed-off-by: Benjamin Brahmer <[email protected]>
Grotax
added a commit
that referenced
this pull request
Nov 19, 2024
This is a major new release with a lot of changes. The frontend of news was rewritten from scratch to change to Vue.js coming from the original implementation with AngularJS. Also we require PHP 8.2 now and support Nextcloud 29 and 30. For the full Changelog checkout the entries for 25.0.0-alpha1 to 25.0.0. Changes since 25.0.0-alpha14 The following changes and fixes were done since the last alpha version 14. Changed - If title of feed is empty during creation set hostname of feed as title (#2872) - Add command to import OPML file - Add API to import OPML file or request body - add import/export `opml` to user settings (#2541) - Remove non-functional unread and starred filter - add single column layout (compact mode) (#2505) - add horizontal split layout (expanded compact mode) (#2505) - Allow to further drag the `feedview` list (and/or provide alternative view) (#2505) Fixed - Feed without Title returned by DB causes exception (#2872) - Keep Unread is now respected during mark read on scroll and is kept during feed/folder changes Signed-off-by: Benjamin Brahmer <[email protected]>
Merged
Grotax
added a commit
that referenced
this pull request
Nov 19, 2024
This is a major new release with a lot of changes. The frontend of news was rewritten from scratch to change to Vue.js coming from the original implementation with AngularJS. Also we require PHP 8.2 now and support Nextcloud 29 and 30. For the full Changelog checkout the entries for 25.0.0-alpha1 to 25.0.0. Changes since 25.0.0-alpha14 The following changes and fixes were done since the last alpha version 14. Changed - If title of feed is empty during creation set hostname of feed as title (#2872) - Add command to import OPML file - Add API to import OPML file or request body - add import/export `opml` to user settings (#2541) - Remove non-functional unread and starred filter - add single column layout (compact mode) (#2505) - add horizontal split layout (expanded compact mode) (#2505) - Allow to further drag the `feedview` list (and/or provide alternative view) (#2505) Fixed - Feed without Title returned by DB causes exception (#2872) - Keep Unread is now respected during mark read on scroll and is kept during feed/folder changes Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While testing the new opml import function and trying to export the feeds from my dev server as opml I came across this issue again, since #869 and #2745 it is possible to add feeds without a title.
But this is causing other issues for example when you try to export your feeds because the DB Feed Entity expects the title to be a string.
With my changes it is now ok if a feed title is null, that should allow people to see feeds even when they do not have a title.
This is of course not optimal because a feed without a title is hard to identify in the feed list, if the feed has a logo or favicon you at least see that else you just see an empty line. You are still able to call open the menu though to remove or rename the feed.
So I also added a check if the title is null during the first creation of the feed and decided to use the hostname of the url that the user entered when adding the feed, which might differ from the actual feed url since some blogs and I think especially podcasts use some cdn for that.
Hope this fixes the last issues.
Checklist