-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build(deps): Bump debril/feed-io from 5.3.1 to 5.3.2 #2398
Conversation
Bumps [debril/feed-io](https://github.com/alexdebril/feed-io) from 5.3.1 to 5.3.2. - [Release notes](https://github.com/alexdebril/feed-io/releases) - [Commits](alexdebril/feed-io@v5.3.1...v5.3.2) --- updated-dependencies: - dependency-name: debril/feed-io dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Seems like the behaviour changed we need to check the tests |
So for the first test in the cli tests. The no GUID feed is now working I guess a side effect of the changes in feed-io. Here a snippet of the items in my dev setup after adding the feed. Details
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2398 +/- ##
============================================
- Coverage 89.28% 0 -89.29%
============================================
Files 67 0 -67
Lines 3239 0 -3239
============================================
- Hits 2892 0 -2892
+ Misses 347 0 -347 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Benjamin Brahmer <[email protected]>
4e825f0
to
72c0748
Compare
Signed-off-by: Benjamin Brahmer <[email protected]>
So the reason why the updater tests failed was the missing id from my test feed that come from my small feed generator tool. I'm not sure if this is an indicator that feeds in the wild might not work anymore after we merge this. |
Bumps debril/feed-io from 5.3.1 to 5.3.2.
Release notes
Sourced from debril/feed-io's releases.
Commits
7c206ea
Fix: Release/5.3.x Support relative links (#422)d8dcd77
Fix linting issueMost Recent Ignore Conditions Applied to This Pull Request
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)