Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build(deps): Bump debril/feed-io from 5.3.1 to 5.3.2 #2398

Merged
merged 3 commits into from
Oct 28, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 25, 2023

Bumps debril/feed-io from 5.3.1 to 5.3.2.

Release notes

Sourced from debril/feed-io's releases.

Turn relative links into absolute ones

What's Changed

Full Changelog: alexdebril/feed-io@v5.3.1...v5.3.2

Commits

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
debril/feed-io [>= 6.a, < 7]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [debril/feed-io](https://github.com/alexdebril/feed-io) from 5.3.1 to 5.3.2.
- [Release notes](https://github.com/alexdebril/feed-io/releases)
- [Commits](alexdebril/feed-io@v5.3.1...v5.3.2)

---
updated-dependencies:
- dependency-name: debril/feed-io
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file patch Skip-Changelog No changelog update is required, minor change labels Oct 25, 2023
@Grotax
Copy link
Member

Grotax commented Oct 25, 2023

Seems like the behaviour changed we need to check the tests

@Grotax
Copy link
Member

Grotax commented Oct 28, 2023

So for the first test in the cli tests. The no GUID feed is now working I guess a side effect of the changes in feed-io.

Here a snippet of the items in my dev setup after adding the feed.

Details

php ./occ news:item:list admin
[
    {
        "id": 11,
        "guid": "https:\/\/joshuawright.net\/slack-wyrm-911.html",
        "guidHash": "ac475c85fc9a90459aadeef8f57747de",
        "url": "https:\/\/joshuawright.net\/slack-wyrm-911.html",
        "title": "Slack Wyrm 911 - Feeling better",
        "author": null,
        "pubDate": 4079923621,
        "updatedDate": null,
        "body": "",
        "enclosureMime": null,
        "enclosureLink": null,
        "mediaThumbnail": null,
        "mediaDescription": null,
        "feedId": 1,
        "unread": true,
        "starred": false,
        "lastModified": 1698479444,
        "rtl": false,
        "fingerprint": "6c8fe3baad89d2f00681fdbc6356e993",
        "contentHash": "6c8fe3baad89d2f00681fdbc6356e993"
    },
    {
        "id": 10,
        "guid": "https:\/\/joshuawright.net\/slack-wyrm-910.html",
        "guidHash": "abd8ceeb28cc7ac1a1f4d3e855382bde",
        "url": "https:\/\/joshuawright.net\/slack-wyrm-910.html",
        "title": "Slack Wyrm 910 - Cake trip",
        "author": null,
        "pubDate": 4079749974,
        "updatedDate": null,
        "body": "",
        "enclosureMime": null,
        "enclosureLink": null,
        "mediaThumbnail": null,
        "mediaDescription": null,
        "feedId": 1,
        "unread": true,
        "starred": false,
        "lastModified": 1698479444,
        "rtl": false,
        "fingerprint": "21c895fb3b6a4ea8f30d12eedcdd60a1",
        "contentHash": "21c895fb3b6a4ea8f30d12eedcdd60a1"
    },
    {
        "id": 9,
        "guid": "http:\/\/www.joshuawright.net",
        "guidHash": "0a65ec5cd415b3d3f9117d482d7baf56",
        "url": "http:\/\/www.joshuawright.net",
        "title": "Slack Wyrm 909 - Cake time",
        "author": null,
        "pubDate": 4079492972,
        "updatedDate": null,
        "body": "",
        "enclosureMime": null,
        "enclosureLink": null,
        "mediaThumbnail": null,
        "mediaDescription": null,
        "feedId": 1,
        "unread": true,
        "starred": false,
        "lastModified": 1698479444,
        "rtl": false,
        "fingerprint": "1724066585c990ce62dda07051745eb3",
        "contentHash": "1724066585c990ce62dda07051745eb3"
    },

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6de4554) 89.28% compared to head (4e825f0) 0.00%.
Report is 3 commits behind head on master.

❗ Current head 4e825f0 differs from pull request most recent head 87c4f88. Consider uploading reports for the commit 87c4f88 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #2398       +/-   ##
============================================
- Coverage     89.28%       0   -89.29%     
============================================
  Files            67       0       -67     
  Lines          3239       0     -3239     
============================================
- Hits           2892       0     -2892     
+ Misses          347       0      -347     

see 67 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Benjamin Brahmer <[email protected]>
@Grotax Grotax force-pushed the dependabot/composer/debril/feed-io-5.3.2 branch from 4e825f0 to 72c0748 Compare October 28, 2023 08:09
Signed-off-by: Benjamin Brahmer <[email protected]>
@Grotax
Copy link
Member

Grotax commented Oct 28, 2023

So the reason why the updater tests failed was the missing id from my test feed that come from my small feed generator tool.
It was simply not needed to set that before.
The effect in the DB was that the items did not get added as expected.
I changed the code of my tool to also set the ID and to set also logical correct urls for our test case.

I'm not sure if this is an indicator that feeds in the wild might not work anymore after we merge this.

@Grotax Grotax requested a review from SMillerDev October 28, 2023 08:50
@Grotax Grotax merged commit 66c2121 into master Oct 28, 2023
17 of 21 checks passed
@delete-merged-branch delete-merged-branch bot deleted the dependabot/composer/debril/feed-io-5.3.2 branch October 28, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file patch Skip-Changelog No changelog update is required, minor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants