fixup

Signed-off-by: Benjamin Brahmer <[email protected]>
nextcloud · Dec 29, 2024 · 8e2c398 · 8e2c398
1 parent 219b1c3
commit 8e2c398
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/lib/Service/FeedServiceV2.php b/lib/Service/FeedServiceV2.php
@@ -18,14 +18,15 @@
 use FeedIo\Reader\ReadErrorException;
 use FeedIo\Reader\NoAccurateParserException;
 use HTMLPurifier;
-use OCP\IAppConfig;
 
 use OCA\News\Db\FeedMapperV2;
 use OCA\News\Fetcher\FeedFetcher;
+use OCA\News\AppInfo\Application;
 use OCA\News\Service\Exceptions\ServiceConflictException;
 use OCA\News\Service\Exceptions\ServiceNotFoundException;
 use OCP\AppFramework\Db\Entity;
 use OCP\AppFramework\Db\DoesNotExistException;
+use OCP\IAppConfig;
 
 use OCA\News\Db\Feed;
 use OCA\News\Db\Item;
@@ -286,7 +287,11 @@ public function fetch(Entity $feed): Entity
         }
 
         // Check if the nextUpdateTime check should be used
-        $useNextUpdateTime = $this->config->getAppValue('news', 'useNextUpdateTime', 'true') === 'true';
+        $useNextUpdateTime = $this->config->getValueBool(
+            Application::NAME,
+            'useNextUpdateTime',
+            Application::DEFAULT_SETTINGS['useNextUpdateTime']
+        );
 
         if ($useNextUpdateTime) {
             $nextUpdateTime = $feed->getNextUpdateTime();

diff --git a/tests/Unit/Service/FeedServiceTest.php b/tests/Unit/Service/FeedServiceTest.php
@@ -123,12 +123,6 @@ protected function setUp(): void
             ->disableOriginalConstructor()
             ->getMock();
 
-        // Mock the getAppValue method
-        $this->config->method('getAppValue')
-        ->willReturnMap([
-            ['news', 'useNextUpdateTime', 'true', 'true'],
-        ]);
-
         $this->class = new FeedServiceV2(
             $this->mapper,
             $this->fetcher,