Skip to content

fix(dynamite): Skip comparing nullable in type results - #519

Merged
provokateurin merged 2 commits into
mainfrom
fix/dynamite-duplicate-types
Aug 1, 2023
Merged

provokateurin merged 2 commits into
mainfrom
fix/dynamite-duplicate-types

Conversation

@provokateurin

Copy link
Copy Markdown
Member

In 7a71e01 the whole type was added to check if the type is already generated. This breaks #465 as it has enums that are both use as nullable and non-nullable type.

@provokateurin
provokateurin requested a review from Leptopoda July 31, 2023 09:45

@Leptopoda Leptopoda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could now also cleanup this:

patch.txt

@provokateurin
provokateurin merged commit 45c8117 into main Aug 1, 2023
@provokateurin
provokateurin deleted the fix/dynamite-duplicate-types branch August 1, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants