Skip to content

fix(dynamite): add serializers of parameter types - #501

Merged
Leptopoda merged 5 commits into
mainfrom
fix/dynamite_parameter_serializer
Jul 30, 2023
Merged

Leptopoda merged 5 commits into
mainfrom
fix/dynamite_parameter_serializer

Conversation

@Leptopoda

Copy link
Copy Markdown
Member

fixes the issue observed in #465

@Leptopoda
Leptopoda requested a review from provokateurin July 17, 2023 18:58
@Leptopoda
Leptopoda force-pushed the fix/dynamite_parameter_serializer branch from 52b153c to 426390f Compare July 17, 2023 19:11
@Leptopoda
Leptopoda force-pushed the fix/dynamite_parameter_serializer branch from 426390f to 6db0cb3 Compare July 17, 2023 19:48
@Leptopoda

Copy link
Copy Markdown
Member Author

In theory we could now remove the serializer code generated by built_value as we already register all serializers.
This would recude duplicate initialization of them.

@provokateurin

Copy link
Copy Markdown
Member

Deduplicating sounds good

@provokateurin provokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to regenerate the nextcloud package

@Leptopoda
Leptopoda requested a review from provokateurin July 30, 2023 15:26
@Leptopoda
Leptopoda merged commit 1df5101 into main Jul 30, 2023
@Leptopoda
Leptopoda deleted the fix/dynamite_parameter_serializer branch July 30, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants