Skip to content

Remove auto upload tip #3832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 23, 2025
Merged

Remove auto upload tip #3832

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca4ba88
Remove tip
mpivchev Oct 22, 2025
3da69b9
Refactor
mpivchev Oct 22, 2025
6e7da91
More refactoring
mpivchev Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 0 additions & 43 deletions iOSClient/Settings/AutoUpload/NCAutoUploadModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,6 @@ class NCAutoUploadModel: ObservableObject, ViewOnAppearHandling {
requestAuthorization()

if !autoUploadImage && !autoUploadVideo { autoUploadImage = true }

showTip()
}

func onViewDisappear() {
Expand Down Expand Up @@ -271,47 +269,6 @@ class NCAutoUploadModel: ObservableObject, ViewOnAppearHandling {
}
}

extension NCAutoUploadModel: EasyTipViewDelegate {
func showTip() {
guard !session.account.isEmpty,
!database.tipExists(NCGlobal.shared.tipAutoUploadButton)
else {
return
}

var preferences = EasyTipView.Preferences()

preferences.drawing.foregroundColor = .white
preferences.drawing.backgroundColor = .lightGray
preferences.drawing.textAlignment = .left
preferences.drawing.arrowPosition = .any
preferences.drawing.cornerRadius = 10

preferences.animating.dismissTransform = CGAffineTransform(translationX: 0, y: 100)
preferences.animating.showInitialTransform = CGAffineTransform(translationX: 0, y: -100)
preferences.animating.showInitialAlpha = 0
preferences.animating.showDuration = 0.5
preferences.animating.dismissDuration = 0.5

if tip == nil {
tip = EasyTipView(text: NSLocalizedString("_tip_autoupload_button_", comment: ""), preferences: preferences, delegate: self, tip: NCGlobal.shared.tipAutoUploadButton)
DispatchQueue.main.asyncAfter(deadline: .now() + 1) {
if let view = self.controller?.tabBar {
self.tip?.show(forView: view)
}
}
}
}

func easyTipViewDidTap(_ tipView: EasyTipView) {
database.addTip(NCGlobal.shared.tipAutoUploadButton)
}

func easyTipViewDidDismiss(_ tipView: EasyTipView) {
tip = nil
}
}

/// An enum that represents the granularity of the subfolders for auto upload
enum Granularity: Int {
/// Daily granularity, meaning the subfolders are named by day
Expand Down
Loading