Conversation
solracsf
added
3. to review
getBaseStorageForFolderRootJail() skips the ACL wrapper for the trash storage because the trash backend does its own ACL filtering, but the separate storage path never got the same guard. createFolder() always uses separate storages now, so every recently created folder ends up with the wrapper on its trash. The visible effect is a permanent delete that can never succeed. ACLStorageWrapper sits below the jail, so it sees the trash paths, and its unlink() runs canDeleteTree() over them. A deny delete rule follows a file's id into the trash, so permanently deleting the folder that file was in fails with "Failed to remove item from trashbin", even though the trash backend already decided the user is allowed to delete that item. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
force-pushed
the
fix/no-acl-wrapper-on-trash-storage
branch
from
August 26, 2026 18:28
93f6f49 to
fb709bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getBaseStorageForFolderRootJail()skips the ACL wrapper for the trash storage because the trash backend does its own ACL filtering. The separate storage path never got the same guard, andcreateFolder()always uses separate storages now.ACLStorageWrappersits below the jail, so itsunlink()runscanDeleteTree()over the trash paths. A deny delete rule follows a file's id into the trash, so permanently deleting the folder that file was in fails withFailed to remove item from trashbin, even though the trash backend already allowed the delete.