[stable31] chore(deps): Bump pdfjs-dist from 3.11.174 to 4.0.189 #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [pdfjs-dist](https://github.com/mozilla/pdfjs-dist) from 3.11.174 to 4.0.189. - [Commits](https://github.com/mozilla/pdfjs-dist/commits) --- updated-dependencies: - dependency-name: pdfjs-dist dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
The "viewer.php" acts as the "viewer.html" file included in the PDF.js package. This commit updates "viewer.php" with the changes to "viewer.html" from PDF.js 3.11.174 to 4.0.189 while respecting the customized parts of "viewer.php". Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
dependencies
|
@danxuliu red CI - related |
Yes and no :-) It is a false positive, because the check fails whenever viewer.html was modified, even if viewer.php was adjusted as needed (which it was in this pull request, see the second commit). For context that check was added to avoid automatic merges of PDF.js version bumps without a human adjusting viewer.php (but once a human adjusts it a force merge is needed 🤷). |
danxuliu
deleted the
backport/1131/stable31-dependabot/npm_and_yarn/pdfjs-dist-4.0.189
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1131