Use --option=value version for occ maintenance:install - #9571
Merged
Conversation
This was
linked to
issues
Jan 20, 2023
This was referenced Jan 20, 2023
MichaIng
enabled auto-merge
January 31, 2023 23:55
The `--option=value` version of passing options to the `occ maintenance:install` command is now used in the documentation, instead of the `--option value` variant. This solves issues with leading dashes in values, especially passwords. It also matches the `occ help maintenance:install` output. Solves: - nextcloud/server#26109 - #8190 Furthermore values are now single quoted, which is important to avoid variable expansion and special treatment of the backlash character in random passwords, and a doubled space was removed. Signed-off-by: MichaIng <micha@dietpi.com>
MichaIng
force-pushed
the
fix/--option=value
branch
from
March 7, 2023 22:37
5abdcb9 to
36e71e4
Compare
ChristophWurst
approved these changes
Apr 3, 2023
Member
|
/backport to stable26 |
Member
|
/backport to stable25 |
This was referenced Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--option=valueversion of passing options to theocc maintenance:installcommand is now used in the documentation, instead of the--option valuevariant. This solves issues with leading dashes in values, especially passwords. It also matches theocc help maintenance:installoutput.Solves:
Furthermore values are now single quoted, which is important to avoid variable expansion and special treatment of the backlash character in random passwords, and a doubled space was removed.