Improve readability and completedness for Redis - #9093
Conversation
- give more complete examples for Redis config - use separate sections for the different connection types (TCP, TLS, socket) Signed-off-by: Martin R眉egg <martin.rueegg@metaworx.ch>
blizzz
left a comment
There was a problem hiding this comment.
Great improvement, few nitpicks :)
Explain that using Redis for local cache is possible, but not recommended Signed-off-by: Martin R眉egg <martin.rueegg@metaworx.ch>
|
Thanks @blizzz for taking the time for reviewing this. |
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Martin R眉egg <martin.rueegg@metaworx.ch>
Co-authored-by: Carl Schwan <carl@carlschwan.eu> Signed-off-by: Martin R眉egg <martin.rueegg@metaworx.ch>
- replace "memcache" with "data cache" in the introduction to avoid confusion with "memcached" - moving the "Recommendations" section to the top of the page (between intro and cache configuration) - re-organize and expand the "Recommendations* section Signed-off-by: Martin R眉egg <martin.rueegg@metaworx.ch>
Signed-off-by: Martin R眉egg <martin.rueegg@metaworx.ch>
|
@nickvergessen, @blizzz, @CarlSchwan are you happy with the changes I made following your request? |
|
I'm fine but I have little to no background to verify the content of your changes |
|
@blizzz can you approve? :) |
|
All points raised by @blizzz regard information/sections, that have already been there before. I am not able to technically review the content of the entire document. But if additional changes are required then I suggest to proceed as follows:
Otherwise, we keep on the improvements in this PR from being published, and potentially helping users/admins. Just because the document should have been overhauled/redacted technically already. What do you guys say? |
|
Thanks, @skjnldsv. |
|
Thanks for your patience @martin-rueegg 馃 |
|
I found
for https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/caching_configuration.html#redis-configuration-in-nextcloud-config-php but not https://docs.nextcloud.com/server/25/admin_manual/configuration_server/caching_configuration.html. Does that mean with Nextcloud >= using Redis for local cache is not problematic? Otherwise I would suggest to backport the refinements of our recommendation. |
|
My remark is specifically about b502cc7. We can also only backport this one commit and leave the restructuring for 26+. |
It's funny, because when I created this PR back in July last year, versions 22-24 where actively released. Don't think any of the examples I've added have been unavailable at that point. So why would it not be back ported to at least v24 or even before? |
Signed-off-by: Martin R眉egg martin.rueegg@metaworx.ch