[stable33] fix(dev): Correct errors in DI chapter code examples - #14707
Merged
Merged
Conversation
Couple code example errors fixed in DI chapter: - `AuthorMappers` referenced when `AuthorMapper` was intended - Class `APIController`, which is shown calling a parent class constructor, wasn't extending a class Also: - Added a DI introduction section - Added some new inline code comments Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
fix(developer): improve `dependency_injection` article Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Christian Wolf <github@christianwolf.email> Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com> [skip ci]
Member
|
@copilot check the original PR and fix the backport |
skjnldsv
marked this pull request as ready for review
May 1, 2026 14:41
…rMapper) Agent-Logs-Url: https://github.com/nextcloud/documentation/sessions/1c4f547a-dfc0-437f-8427-722e03179f75 Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com>
Contributor
Fixed in cb3723e. The backport was missing one fix from the original PR: in the "How the container works" section, the |
skjnldsv
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #13840
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.