Skip to content

update layout page - #10397

Merged
szaimen merged 6 commits into
masterfrom
enh/noid/update-layout-screenshots
May 25, 2023
Merged

update layout page#10397
szaimen merged 6 commits into
masterfrom
enh/noid/update-layout-screenshots

Conversation

@szaimen

@szaimen szaimen commented May 16, 2023

Copy link
Copy Markdown
Contributor

Address part of #10392

TODO:

  • Update all screenshots
  • add links to penpot?
  • address reviews

Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen added this to the Nextcloud 27 milestone May 16, 2023
Comment thread developer_manual/images/mail-layout.png
Comment thread developer_manual/images/talk-layout.png
@szaimen szaimen mentioned this pull request May 16, 2023
5 tasks
@szaimen
szaimen marked this pull request as ready for review May 23, 2023 14:41
@szaimen
szaimen requested a review from nimishavijay May 23, 2023 14:42
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@szaimen szaimen changed the title update layout screenshots update layout page May 24, 2023
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: Simon L <szaimen@e.mail.de>
Comment thread developer_manual/design/layout.rst Outdated
Comment thread developer_manual/design/layout.rst Outdated

@jancborchardt jancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments on links, otherwise good!

Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen
szaimen requested a review from jancborchardt May 24, 2023 14:13
@jancborchardt

Copy link
Copy Markdown
Member

Small comment on the link <>, and I guess blocking still cause of the Mail screenshot here too?

Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen
szaimen requested review from jancborchardt and removed request for jancborchardt May 25, 2023 14:50
@szaimen
szaimen merged commit 72f91ce into master May 25, 2023
@szaimen
szaimen deleted the enh/noid/update-layout-screenshots branch May 25, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants