Skip to content

feat(user_manual): document system address book - #10264

Merged
ChristophWurst merged 1 commit into
masterfrom
enh/user_manual/document-system-addressbook
May 12, 2023
Merged

ChristophWurst merged 1 commit into
masterfrom
enh/user_manual/document-system-addressbook

Conversation

@miaulalala

@miaulalala miaulalala commented May 4, 2023

Copy link
Copy Markdown
Contributor

☑️ Resolves

🖼️ Screenshots

Before After
screencapture-127-0-0-1-8000-userpreferences-html-2023-05-04-16_51_34 screencapture-127-0-0-1-8000-userpreferences-html-2023-05-04-16_47_45
screencapture-127-0-0-1-8000-groupware-contacts-html-2023-05-04-16_50_48 screencapture-127-0-0-1-8000-groupware-contacts-html-2023-05-04-16_48_24

Comment thread user_manual/userpreferences.rst Outdated
@ChristophWurst

Copy link
Copy Markdown
Member

There is no documentation that wouldn't be true with the current SAB implementation. We can already merge this PR, even if nextcloud/server#37734 is not in yet.

@ChristophWurst

Copy link
Copy Markdown
Member

Conventional commits are not checked here but fyi feat(user_manual) is an invalid scope. I know because I made the mistake myself until @st3iny pointed it out. The scope should only be alphanumeric, so feat(usermanual)

👻

@ChristophWurst
ChristophWurst marked this pull request as ready for review May 12, 2023 07:13
@ChristophWurst
ChristophWurst requested a review from hamza221 as a code owner May 12, 2023 07:13
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala
miaulalala force-pushed the enh/user_manual/document-system-addressbook branch from cd642da to b189035 Compare May 12, 2023 12:19
@ChristophWurst

Copy link
Copy Markdown
Member

we have not branched off yet, master=27

@ChristophWurst
ChristophWurst merged commit 1496839 into master May 12, 2023
@ChristophWurst
ChristophWurst deleted the enh/user_manual/document-system-addressbook branch May 12, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

Document system addressbook

2 participants