Skip to content

refactor(pinia): migrate dashboard store - #8128

Merged
grnd-alt merged 1 commit into
mainfrom
refactor/pinia-migration-dashboardStore
Jul 2, 2026
Merged

refactor(pinia): migrate dashboard store#8128
grnd-alt merged 1 commit into
mainfrom
refactor/pinia-migration-dashboardStore

Conversation

@grnd-alt

@grnd-alt grnd-alt commented Jul 2, 2026

Copy link
Copy Markdown
Member

No description provided.

@grnd-alt
grnd-alt requested review from max-nextcloud and mejo- July 2, 2026 11:27
@grnd-alt
grnd-alt requested a review from luka-nextcloud as a code owner July 2, 2026 11:27
@grnd-alt
grnd-alt force-pushed the refactor/pinia-migration-dashboardStore branch from f0b6cfd to 93893d4 Compare July 2, 2026 11:27
Comment thread src/init-dashboard.js
Vue.prototype.OC = OC
const pinia = createPinia()
Vue.use(PiniaVuePlugin)
Vue.use(Vuex)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are still injecting vuex here because some components in the dashboard require vuex state from not yet migrated stores. for example: https://github.com/nextcloud/deck/blob/main/src/components/cards/badges/DueDate.vue#L48

Signed-off-by: grnd-alt <git@belakkaf.net>
@grnd-alt
grnd-alt force-pushed the refactor/pinia-migration-dashboardStore branch from 93893d4 to 974a642 Compare July 2, 2026 11:40

@mejo- mejo- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only looked through the code and didn't spot anything obvious.

@grnd-alt
grnd-alt merged commit 393a7e8 into main Jul 2, 2026
35 checks passed
@grnd-alt
grnd-alt deleted the refactor/pinia-migration-dashboardStore branch July 2, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants