Skip to content

Fix missing due date remember icons #7626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theoholl wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix missing due date remember icons #7626

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
711373e
Add default icon and load settings lazily
theoholl Mar 12, 2026
8d352dd
Restore shared board reminder labels and lazy-load settings on menu open
theoholl Mar 15, 2026
610d277
Give submenu items regular font weight
theoholl Mar 17, 2026
1c28b03
Merge branch 'main' into 7511-missing-icons-on-shared-boards-dropdown
theoholl Mar 17, 2026
0d0b32d
Fix linting errors
theoholl Mar 17, 2026
0bb7863
Merge branch 'main' into 7511-missing-icons-on-shared-boards-dropdown
theoholl Mar 24, 2026
78736d4
Merge branch 'main' into 7511-missing-icons-on-shared-boards-dropdown
theoholl May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 24 additions & 23 deletions src/components/navigation/AppNavigationBoard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,9 @@
</NcActionButton>
</template>
<NcActionButton v-else-if="!board.archived && board.acl?.length > 0"
:name="t('deck', 'Due date reminders')"
:icon="dueDateReminderIcon"
@click="isDueSubmenuActive=true">
{{ dueDateReminderText }}
icon="icon-sound"
@click="openDueReminderMenu">
{{ t('deck', 'Due date reminders') }}
</NcActionButton>

<NcActionButton v-if="canManage && !isDueSubmenuActive"
Expand Down Expand Up @@ -238,6 +237,7 @@ export default {
editColor: '',
isDueSubmenuActive: false,
updateDueSetting: null,
loadingDueReminderSettings: false,
canCreate: canCreateState,
cloneModalOpen: false,
exportModalOpen: false,
Expand Down Expand Up @@ -267,25 +267,8 @@ export default {
canLeave() {
return this.board.acl?.find((acl) => acl.participant.uid === this.currentUser?.uid && acl.participant.type === 0) !== undefined
},
dueDateReminderIcon() {
if (this.board.settings['notify-due'] === 'all') {
return 'icon-sound'
} else if (this.board.settings['notify-due'] === 'assigned') {
return 'icon-user'
} else if (this.board.settings['notify-due'] === 'off') {
return 'icon-sound-off'
}
return ''

@grnd-alt grnd-alt Mar 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't remove that code, we can still show the correct icon (same for the text).
You can use the @update:menuOpen hook on the NcAppNavigationItem in line 16, so when the menu is opened you can load the settings. I think that's the best option because then we don't show an icon only until the board is loaded and then have the correct one displayed.

@theoholl theoholl Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, should be ok now?

},
dueDateReminderText() {
if (this.board.settings['notify-due'] === 'all') {
return t('deck', 'All cards')
} else if (this.board.settings['notify-due'] === 'assigned') {
return t('deck', 'Only assigned cards')
} else if (this.board.settings['notify-due'] === 'off') {
return t('deck', 'No reminder')
}
return ''
hasDueDateReminderSetting() {
return ['all', 'assigned', 'off'].includes(this.board.settings?.['notify-due'])
},
isDefaultBoard() {
return this.defaultBoardId === String(this.board.id)
Expand Down Expand Up @@ -417,6 +400,24 @@ export default {
cancelEdit(e) {
this.editing = false
},
async openDueReminderMenu() {
this.isDueSubmenuActive = true

if (this.hasDueDateReminderSetting || this.loadingDueReminderSettings) {
return
}

this.loadingDueReminderSettings = true

try {
await this.$store.dispatch('hydrateBoardSettings', this.board.id)
} catch (error) {
OC.Notification.showTemporary(t('deck', 'Failed to load due date reminder settings'))
console.error(error)
} finally {
this.loadingDueReminderSettings = false
}
},
async updateSetting(key, value) {
this.updateDueSetting = value
const setting = {}
Expand Down
22 changes: 22 additions & 0 deletions src/store/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,23 @@ export default function storeFactory() {
setCurrentCard(state, card) {
state.currentCard = card
},
setBoardSettings(state, { boardId, settings }) {
const indexExisting = state.boards.findIndex((board) => board.id === boardId)

if (indexExisting > -1) {
Vue.set(state.boards[indexExisting], 'settings', {
...(state.boards[indexExisting].settings || {}),
...settings,
})
}

if (state.currentBoard?.id === boardId) {
Vue.set(state.currentBoard, 'settings', {
...(state.currentBoard.settings || {}),
...settings,
})
}
},

// label mutators
removeLabelFromCurrentBoard(state, labelId) {
Expand Down Expand Up @@ -309,6 +326,11 @@ export default function storeFactory() {
setFullApp({ commit }, isFullApp) {
commit('setFullApp', isFullApp)
},
async hydrateBoardSettings({ commit }, boardId) {
const board = await apiClient.loadById(boardId)
commit('setBoardSettings', { boardId, settings: board.settings || {} })
return board.settings || {}
},
async setConfig({ commit }, config) {
for (const key in config) {
try {
Expand Down
Loading